Skip to content

ci(v5.1): sync the ready_for_review non-cancelling fix #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heskew merged 8 commits into from
Aug 27, 2026
Merged

ci(v5.1): sync the ready_for_review non-cancelling fix #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f351585
ci(v5.1): sync bot caller workflows with main
heskew Aug 25, 2026
3cc4afd
ci: adopt ai-review-prompts #90 cost gates (pin be549ad) + ready_for_…
heskew Aug 26, 2026
1206e46
ci: admit ready_for_review on label-opted PRs in opt-in mode
heskew Aug 26, 2026
a7a5517
ci: keep ineligible runs out of the review concurrency group
heskew Aug 26, 2026
a9af33e
ci: only the provider's own label makes a labeled run eligible
heskew Aug 26, 2026
706f969
ci: ready_for_review runs review but never cancels
heskew Aug 26, 2026
1958e61
Merge v5.1 (post #2330 squash) — sync branch content stands
heskew Aug 26, 2026
7db2df8
ci: exclude ready_for_review from the always-on cancelling arm (see #…
heskew Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/claude-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,15 @@ on:
types: [opened, synchronize, reopened, ready_for_review, labeled]

concurrency:
# NOTE: this predicate and the review job's `if:` must stay textually
# in sync — GitHub Actions YAML has no anchors to share them.
# NOTE: this predicate is deliberately NARROWER than the review job's
# `if:` — the cancelling set must be a subset of the running set.
# ready_for_review runs review (job gate) but never cancel: their
# authorization is author-based, so on a bot-authored PR they could
# kill a labeler-authorized run and then be rejected themselves.
# Ineligible events (per the review job's opt-in gate) get a unique
# run_id group so they can never cancel an in-flight eligible review —
# workflow-level cancel-in-progress fires before job `if:` is evaluated.
group: claude-review-${{ github.event.pull_request.number }}-${{ ((github.event.action == 'labeled' && github.event.label.name == 'claude-review') || (github.event.action != 'labeled' && vars.CLAUDE_ALWAYS_ON == 'true') || (github.event.action == 'ready_for_review' && contains(github.event.pull_request.labels.*.name, 'claude-review'))) && 'eligible' || github.run_id }}
group: claude-review-${{ github.event.pull_request.number }}-${{ ((github.event.action == 'labeled' && github.event.label.name == 'claude-review') || (github.event.action != 'labeled' && github.event.action != 'ready_for_review' && vars.CLAUDE_ALWAYS_ON == 'true')) && 'eligible' || github.run_id }}
cancel-in-progress: true

jobs:
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/gemini-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,13 @@ concurrency:
# in parallel on the same PR. cancel-in-progress is per-group, so a
# synchronize push cancels the in-flight Gemini run without touching
# the Claude run (and vice versa).
# NOTE: this predicate and the review job's `if:` must stay textually
# in sync — GitHub Actions YAML has no anchors to share them.
# NOTE: this predicate is deliberately NARROWER than the review job's
# `if:` — the cancelling set must be a subset of the running set.
# ready_for_review runs review (job gate) but never cancel: their
# authorization is author-based, so on a bot-authored PR they could
# kill a labeler-authorized run and then be rejected themselves.
# Ineligible events get a unique run_id group — see claude-review.yml.
group: gemini-review-${{ github.event.pull_request.number }}-${{ ((github.event.action == 'labeled' && github.event.label.name == 'gemini-review') || (github.event.action != 'labeled' && vars.GEMINI_ALWAYS_ON == 'true') || (github.event.action == 'ready_for_review' && contains(github.event.pull_request.labels.*.name, 'gemini-review'))) && 'eligible' || github.run_id }}
group: gemini-review-${{ github.event.pull_request.number }}-${{ ((github.event.action == 'labeled' && github.event.label.name == 'gemini-review') || (github.event.action != 'labeled' && github.event.action != 'ready_for_review' && vars.GEMINI_ALWAYS_ON == 'true')) && 'eligible' || github.run_id }}
cancel-in-progress: true

jobs:
Expand Down
Loading