ci: ready_for_review runs review but never cancels - #2353
Merged
Conversation
kriszyp follow-up finding on the harper-pro twin (harper-pro#767): the label-opted ready_for_review event sat in the shared eligible concurrency group, so on a bot-authored PR it could cancel the trusted labeler's in-flight review and then be rejected by author-based authorization — no completed review. The cancelling set (concurrency predicate) now excludes ready_for_review; the running set (job gate) keeps it. Revisit if the reusable gains persisted-label authorization. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S94XethbGXpAb4DRKMD4kt
github-actions
Bot
requested review from
Ethan-Arrowood,
cb1kenobi and
kriszyp
August 26, 2026 21:15
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
heskew
added a commit
that referenced
this pull request
Aug 27, 2026
Codex follow-up on #2353: ready_for_review is a non-labeled event, so the ALWAYS_ON arm of the concurrency predicate still placed it in the shared cancelling group in always-on mode — a label-opted bot PR's ready-flip could cancel the labeler's in-flight review and then fail author-based authorization. The cancelling set now excludes ready_for_review in BOTH modes; the job gates are unchanged (ready-flips run review, in their own run_id group). Claude-Session: https://claude.ai/code/session_01S94XethbGXpAb4DRKMD4kt Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2348, from @kriszyp's finding on harper-pro#767: the label-opted
ready_for_reviewevent shared theeligibleconcurrency group, so on a bot-authored PR it could cancel the trusted labeler's in-flight review and then be rejected by author-based authorization (non-labeled events authorize against the PR author, not the labeler) — leaving no completed review.Fix: the cancelling set (concurrency predicate) excludes
ready_for_review; the running set (job gate) keeps it. Trusted-author ready-flips still get their review — they just can't kill anyone else's. The two predicates now deliberately diverge, with the comment explaining why (cancelling ⊆ running). Revisit if the reusable gains persisted-label authorization.Merge order: before #2330/#2331 (they carry this fix and must stay byte-identical to main).
🤖 Generated with Claude Code
https://claude.ai/code/session_01S94XethbGXpAb4DRKMD4kt