Add the @harperfast/fulltext native package scaffold - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffolds
@harperfast/fulltextas a pinned Rust/Tantivy Node-API package with a public native façade, stable native error boundaries, platform packaging, and a backend-neutral TantivyDirectoryqualification harness. The Rocks façade remains intentionally unexported until Phase 0 proves its caller-owned rocksdb-js lease.Closes #9.
For the human reviewer
Directorywill be implemented directly over caller-owned RocksDB instead of materializing filesystem segments. Reversing this remains affordable before the Rocks façade ships; approving it commits Phase 0 to validating durability and read amplification../native;./rocksis added after its lease is proven instead of exposing a placeholder contract. Rejecting this choice delays merging the scaffold or requires committing to an untested ABI.runtimeInfo()is Promise-shaped even though its initial addon load is currently synchronous. Changing this after consumers adopt it would be costly.Verification
npm run check: formatting, TypeScript, Clippy, 6 Rust tests, 7 Node tests, and the packed-package consumer test passed.cargo deny check: advisories, bans, licenses, and sources passed.npm packoutput with consumer lifecycle scripts disabled and its public native entry point loaded successfully. Indexing and search are intentionally not observable in this scaffold.Complexity: complicated
Review-Coverage: authored=codex; ran=claude; adjudicated=domain; declined=gemini,cursor-grok,cursor-composer; rounds=9 @ fd89c05
Human-Review-Need: 4 @ fd89c05