-
Notifications
You must be signed in to change notification settings - Fork 9
docs(cli): token credentials in the canonical auth precedence (v5.2.0) #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a83c869
docs(cli): slot token credentials into the canonical auth precedence
dawsontoth 50292cb
docs(release-notes): cover CI token credentials in 5.2
dawsontoth 613c2e8
docs(cli): a blank token namespace is skipped, not a hard failure
dawsontoth 5bd6ec0
docs(cli): narrow two token-handling claims to what 5.2.4 actually does
dawsontoth f8e5064
docs(cli): split refresh-failure behavior by credential shape
dawsontoth 82412b6
docs(release-notes): scope the refresh-failure caveat to the CI crede…
dawsontoth 4c1da6c
docs(cli): expiry answers 403 and does not halt the command
dawsontoth a8b252d
docs(cli): a lost target falls back to the saved login, not straight …
dawsontoth 8b2c9ea
docs(cli): state the one-credential-style rule once, up front
dawsontoth 9fa2436
docs(cli): point the 403 warning at its tracking issue
dawsontoth f0d42ca
docs(cli): loopback targets make a token failure succeed, not fail
dawsontoth f34693f
docs(cli): resolve the contradiction the loopback bullet created
dawsontoth 8f5c882
docs(cli): the loopback case needs configuration, not a result check
dawsontoth 366b09c
docs(cli): only authorizeLocal:false closes the loopback exposure, an…
dawsontoth 6e8e01b
docs(cli): the socket rule is also the limit of the loopback remediation
dawsontoth 3cd66b4
docs(cli): scope the loopback remediation to a pointer, keep the hazard
dawsontoth 59691d4
docs(security): give authorizeLocal the facts the CLI page defers to it
dawsontoth 1a8dde1
docs(cli): local authorization applies only when no credential is att…
dawsontoth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference/cli/overview.md:160-168still tells CI users to useHARPER_CLI_USERNAME/HARPER_CLI_PASSWORD, omits both token variables, and says the displayed sources are resolved "in the order shown." That leaves the overview inconsistent with this recommendation and the canonical precedence list. Please add token credentials (ideally including the--for-cipath) there, or reword the overview as an intentionally abbreviated list without the ordering claim.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 1a8dde1 — added token credentials with the
--for-cipointer, moved the CI/CD recommendation onto them, and replaced the ordering claim with an explicit note that the list is abbreviated and not in precedence order (pointing at the canonical list for the real order).Thank you for catching this — it is a symmetry miss on my part. I updated
authentication.mdandcommands.mdand never grepped for other pages making precedence claims, which is exactly the check I should have run when the same pattern spans several surfaces. Worth noting the overview also still recommended username/password for CI, which now contradicts the one-style guidance this PR adds, so it was two inconsistencies rather than one.🤖 Addressed by Claude Code