Skip to content

Randomizer - Shuffle Roll (V2) - #7018

Open
TheLynk wants to merge 52 commits into
HarbourMasters:developfrom
TheLynk:ShuffleRollV2
Open

Randomizer - Shuffle Roll (V2)#7018
TheLynk wants to merge 52 commits into
HarbourMasters:developfrom
TheLynk:ShuffleRollV2

Conversation

@TheLynk

@TheLynk TheLynk commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

this branch was completely redone from 0 belonging to the Dev branch

Add new setting randomizer "Shuffle Roll", shuffle ability do a roll for Link
Logic update for Tree and Break Crates

I am not against feedback or ideas for the custom model
And for All language Translation
And for logic

Special Thanks for @DanaTheElf for Model and Icon

List of things to finish :
- Put a definitive icon for the tracker item
- Added to the logic the PR of @Pepper0ni

  • check the logic again for tricks and such

Origin PR : #5956

image image

Build Artifacts

TheLynk added 30 commits July 1, 2025 16:41
@serprex

serprex commented Aug 5, 2026

Copy link
Copy Markdown
Member

@PurpleHato there's some translations here, French text seems a bit long

@serprex

serprex commented Aug 5, 2026

Copy link
Copy Markdown
Member

why icon roc's feather?

@serprex

serprex commented Aug 5, 2026

Copy link
Copy Markdown
Member

we should be able to render model without recording animation (based on internal discussion, this blocks merging)

or ask for different custom asset, @nickel246 did #6783 & @7hrone did #7015

@TheLynk

TheLynk commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

why icon roc's feather?

it's temporary (placeholder)

@djevangelia

Copy link
Copy Markdown
Contributor

z_player is good. Jumping from heights works without the roll.
There is a line doAction = DO_ACTION_ATTACK; which sets the A button text for rolling. I'm not 100% sure it's only set for rolls, but if it is, you could add a hook here to to skip this line for blank A when player doesn't have roll.

Comment thread soh/soh/Enhancements/randomizer/draw.cpp Outdated
Comment thread soh/soh/Enhancements/randomizer/item_list.cpp Outdated
@TheLynk
TheLynk requested a review from PurpleHato August 10, 2026 19:41
@serprex
serprex requested a review from Pepper0ni August 11, 2026 03:34

@PurpleHato PurpleHato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the French translation now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants