refactor[next]: delete dead OTF workflow code (SkippableStep, BindingStep, fast fingerprinter) - #2736
Open
egparedes wants to merge 1 commit into
Open
refactor[next]: delete dead OTF workflow code (SkippableStep, BindingStep, fast fingerprinter)#2736egparedes wants to merge 1 commit into
egparedes wants to merge 1 commit into
Conversation
2 tasks
…Step, fast fingerprinter)
Trivial deletions from the OTF toolchain, the first step of dissolving
'gt4py.next.otf' into a toolchain core and DSL-agnostic build
infrastructure:
- 'otf.workflow.SkippableStep': zero code users; its section in the
WorkflowPatterns guide is removed and the factory example there is
simplified accordingly.
- 'otf.definitions.BindingStep': zero users.
- 'otf.stages.fast_compilable_program_fingerprinter' and its only
(vestigial) consumer 'GTFNBackendFactory.Params.key_function': no
production users left. This also removes 'otf.stages'' only IR-side
imports ('itir', 'common').
No behavior change.
Claude-Session: https://claude.ai/code/session_01R8zRtFMhdJ8c96XJYCXkRk
egparedes
marked this pull request as ready for review
July 30, 2026 17:58
egparedes
force-pushed
the
otf-split-0-trivial-deletions
branch
from
July 30, 2026 17:58
13da480 to
e377ee3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First PR of a stack refactoring the
gt4py.next.otftoolchain (phases 0-4 of theotf-toolchain-splitproposal). This one only deletes dead code, with no behavior change:workflow.SkippableStep: unused combinator (no subclasses, no instantiations in the repo). The corresponding section indocs/user/next/advanced/WorkflowPatterns.mdis removed and theStrToIntFactoryexample simplified to the traits actually demonstrated.stages.fast_compilable_program_fingerprinterand thekey_functionhelper inrunners/gtfn.py: an unused alternative cache-key function. Persistent-cache users (gtfn, dace) all use the strict fingerprinter, which they now reference directly asfingerprinting.strict_fingerprinter.interface.BindingStepprotocol: never implemented by any class; binding steps are plain callables.No public
gtx.*API is affected. Cache keys are unchanged (fingerprints use fully-qualified class names, which none of these deletions touch).Requirements
https://claude.ai/code/session_01R8zRtFMhdJ8c96XJYCXkRk