Skip to content

fix: use lib.name instead of package.name if possible - #98

Merged
GregoryConrad merged 2 commits into
GregoryConrad:mainfrom
iWisp360:main
Aug 18, 2026
Merged

fix: use lib.name instead of package.name if possible#98
GregoryConrad merged 2 commits into
GregoryConrad:mainfrom
iWisp360:main

Conversation

@iWisp360

@iWisp360 iWisp360 commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

when rust compiles the library, and lib.name is defined, the pattern lib{lib.name}.d is used instead of lib{package.name}.d, So this PR covers this.

Previous to this PR, this wouldn't compile

[package]
name = "anb-sys"
version = "0.1.0"
edition = "2024"

[dependencies]
anb = { path = "../anb" }

[build-dependencies]
cbindgen = "0.29.4"

[lib]
name = "anb"
crate-type = ["cdylib", "staticlib"]

Solves #97

@iWisp360 iWisp360 changed the title use lib.name instead of package.name if possible to find the dep-info file use lib.name instead of package.name if possible to find the dep-info file. Solves #97 Aug 17, 2026
@iWisp360 iWisp360 changed the title use lib.name instead of package.name if possible to find the dep-info file. Solves #97 use lib.name instead of package.name if possible to find the dep-info file. Aug 17, 2026
@iWisp360 iWisp360 changed the title use lib.name instead of package.name if possible to find the dep-info file. use lib.name instead of package.name if possible to find the dep-info file Aug 17, 2026
GregoryConrad
GregoryConrad approved these changes Aug 18, 2026
View reviewed changes

@GregoryConrad GregoryConrad left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@GregoryConrad GregoryConrad changed the title use lib.name instead of package.name if possible to find the dep-info file fix: use lib.name instead of package.name if possible Aug 18, 2026
@GregoryConrad
GregoryConrad merged commit bf13159 into GregoryConrad:main Aug 18, 2026
5 of 6 checks passed
@GregoryConrad

GregoryConrad commented Aug 18, 2026

Copy link
Copy Markdown
Owner

If I don’t make a new release this evening, please bug me here for a reminder 😅

@iWisp360

iWisp360 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

If I don’t make a new release this evening, please bug me here for a reminder 😅

Got it, thx for merging

@adil192 adil192 mentioned this pull request Aug 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryConrad GregoryConrad GregoryConrad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iWisp360 @GregoryConrad