chore: rename app ID to io.github.Green2Grey2.QuickView - #6
Conversation
…uickView Placeholder ID replaced everywhere ahead of wider distribution: GTK application id, ProjectDirs qualifier triple in cache.rs, .desktop / metainfo / icon / Flatpak manifest filenames and contents, PKGBUILD install paths, templates, README icon path. Linux cache/config paths derive from the lowercased app name, so ~/.cache/quickview/ is unchanged and existing OCR cache entries stay valid (verified: cache hit after rename). Also drops the empty assets/icons/hicolor/256x256/ directory (packaging only installs the SVG).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2af6354076
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "app-id": "com.example.QuickView", | |||
| "app-id": "io.github.Green2Grey2.QuickView", | |||
There was a problem hiding this comment.
When building or publishing the Flatpak/AppStream metadata, Green2Grey2 is part of the reverse-DNS domain portion (io.github.<owner>), and the Flatpak application-ID conventions say that domain portion must be lowercase (Flatpak docs). Keeping this mixed-case owner makes the renamed ID non-compliant and can block app-center/Flatpak validation; use a lowercase owner such as io.github.green2grey2.QuickView consistently across the manifest, desktop ID, metainfo, icon name, and GApplication ID.
Useful? React with 👍 / 👎.
1 participant
Mechanical rename of the placeholder
com.example.QuickViewapp ID ahead of wider distribution (Phase 6). No code behavior changes.application_idinquickview-ui/src/lib.rsProjectDirs::from("io.github", "Green2Grey2", "QuickView")incache.rs— Linux paths use the lowercased app name, so~/.cache/quickview/does not move; verified an existing OCR cache entry still hits after the renamegit mvof the .desktop, metainfo, SVG icon, and Flatpak manifest (filenames embed the ID) plus their contents, PKGBUILD install paths, templates, README icon pathassets/icons/hicolor/256x256/directory (packaging only installs the SVG)Validation:
desktop-file-validateOK;appstreamcli validateOK (1 info: developer-info-missing, pre-existing);grep -ri com.exampleclean; fmt/clippy/tests green; smoke-launched Quick Preview.