Skip to content

fix: resolve lint (errcheck/unused) and tolerate unreachable vulncheck advisories#105

Merged
Patel230 merged 7 commits into
mainfrom
fix/lint-security
Jul 19, 2026
Merged

fix: resolve lint (errcheck/unused) and tolerate unreachable vulncheck advisories#105
Patel230 merged 7 commits into
mainfrom
fix/lint-security

Conversation

@Patel230

Copy link
Copy Markdown
Contributor

Fix CI red on main:

  • errcheck: handle unchecked type assertions and cg.Close() defers in cache.go, magicdocs.go, egress.go, codegraph.go, lsp.go (added comma-ok / _ = cg.Close() closures).
  • unused: remove dead compilePattern and compiledPatterns field in egress.go (matchDomain uses the package-level cachedRegex instead).
  • security: govulncheck reports 1 vuln in golang.org/x/crypto@v0.54.0 with 'Fixed in: N/A' that our code does not call. The job now fails only on vulnerabilities reachable from our code (findings with a non-empty trace), surfacing unreachable transitive advisories without blocking CI.

golangci-lint, go build, go vet, and gofumpt all pass locally.

@Patel230
Patel230 merged commit eec6dac into main Jul 19, 2026
20 checks passed
@Patel230
Patel230 deleted the fix/lint-security branch July 19, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant