test: fix preflight tests that were skipped due to environment#70
Closed
Patel230 wants to merge 2 commits into
Closed
test: fix preflight tests that were skipped due to environment#70Patel230 wants to merge 2 commits into
Patel230 wants to merge 2 commits into
Conversation
- Added failingStore mock type for deterministic credential fail testing - TestPreflight_NotReady_WhenCredentialsFail now uses failing store - TestPreflight_MultipleFailures now uses failing store - Eliminates environment-dependent test skips
Patel230
enabled auto-merge (squash)
July 16, 2026 04:10
Patel230
disabled auto-merge
July 16, 2026 04:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test failures for preflight check tests by using a failing mock store instead of environment-skipping the tests.
Changes
This ensures the tests properly validate credential failure handling in all environments, not just those where the keychain behaves unexpectedly.