Eliminate N+1 queries in character-order display and editing - #749
Open
DeusExTaco wants to merge 2 commits into
Open
Eliminate N+1 queries in character-order display and editing#749DeusExTaco wants to merge 2 commits into
DeusExTaco wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request optimizes character and story-character ordering queries by introducing a bulk-loading cache (_build_character_identity_cache) for alias and civilian identities, and by batching database operations (using bulk_create and bulk_update) during character reordering. These changes significantly reduce the number of database queries. However, a critical bug was identified in apps/gcd/models/story.py where querying story_character__story_character_id instead of story_character_id for character revisions causes ID mismatches and breaks the editing flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I eliminated the per-character database queries in character-order display and editing flows.
get()for each appearance.Testing
apps/oi/tests/db/test_character_order_revision.py: 7 passedCloses #731