Conversation
build fail patch 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements, most notably adding a public IP display and integrated speed test functionality to the application's UI. It also streamlines the build and release process to use the runtime app version from
app/main.pyas the single source of truth for versioning, ensuring consistency between the UI, build artifacts, and release metadata.Major new features and UI enhancements:
Build and release process improvements:
app/main.pyasAPP_VERSION/VERSIONand is used for the UI, build artifact naming, and release tagging. The build script (build_app.py) extracts this version for packaging, eliminating the need to manually sync version numbers across files. [1] [2] [3] [4] [5]stablebranch instead ofmain. [1] [2] [3] [4]Dependency and packaging updates:
speedtest-clidependency is now explicitly listed inpyproject.toml, and test dependencies are separated. The build process installs requirements fromrequirements.txt. [1] [2]References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]