Conversation
Owner
Author
|
@copilot resolve the merge conflicts in this pull request. Use the newest data and discard all old data. |
Co-authored-by: GoobyFRS <68407017+GoobyFRS@users.noreply.github.com>
Co-authored-by: GoobyFRS <68407017+GoobyFRS@users.noreply.github.com>
Contributor
GoobyFRS
marked this pull request as draft
August 15, 2026 23:59
GoobyFRS
marked this pull request as ready for review
August 15, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several foundational improvements and new features to the Goobs WiFi Scanner project. It adds a structured project layout, centralizes version management, introduces a modular data and service layer, and provides detailed documentation for development, roadmap, and the planned speedtest UI feature. The changes also implement a reusable speedtest service and parsing logic, and refactor Wi-Fi scanning into a dedicated service module.
Project Structure & Versioning Improvements
app,models,services, andutils, and updatedpyproject.tomlfor modern Python packaging and centralized versioning. [1] [2] [3]pyproject.tomlas the single source of truth, with instructions for synchronizing version values acrossapp/__init__.pyandapp/main.py. [1] [2]New Modular Codebase
NetworkRecordinmodels/network.pyand corresponding package initialization. [1] [2]services/wifi_scan.pyand updated service initialization. [1] [2]services/speedtest.py, including robust CLI detection, output parsing, and error handling.Documentation & Roadmap
docs/wiki.md), a roadmap (docs/roadmap.md), and a detailed speedtest UI implementation plan (docs/speedtest_plan.md). These documents clarify the project’s structure, development flow, and future features. [1] [2] [3]README.mdwith updated install/build instructions, versioning flow, and project structure overview. [1] [2]Code Quality and Entry Point
__all__and__version__markers to each package for better maintainability. [1] [2] [3]These changes lay the groundwork for robust future enhancements and simplify both development and maintenance.