Skip to content

char type and string maniuplation - #15

Merged
chadsec1 merged 30 commits into
mainfrom
feat/char-type-and-string-manipulation
Jul 13, 2026
Merged

char type and string maniuplation#15
chadsec1 merged 30 commits into
mainfrom
feat/char-type-and-string-manipulation

Conversation

@chadsec1

@chadsec1 chadsec1 commented Jun 6, 2026

Copy link
Copy Markdown
Member

This pull request adds support for a char type, which is the same char type Rust use, which is guaranteed to always be valid UTF-8.

Only new node is CharLiteral.

And as usual, the PR requests accompanies new unit-tests for char type, and misc bug fixes in general around parser, semantics, transpiler, etc.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codacy-production

codacy-production Bot commented Jul 13, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 367 complexity · 179 duplication

Metric Results
Complexity 367
Duplication 179

View in Codacy

🟢 Coverage 95.23% diff coverage

Metric Results
Coverage variation Report missing for 29a3a231
Diff coverage 95.23% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (29a3a23) Report Missing Report Missing Report Missing
Head commit (65b971e) 3293 3120 94.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15) 566 539 95.23%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR titled 'char type and string maniuplation' is currently empty and does not contain any code changes. Although the intent summary indicates the introduction of a Rust-style char type and various compiler bug fixes, the diff provides no implementation for the char type, the CharLiteral AST node, or the promised unit tests. As a result, all acceptance criteria are unaddressed. This PR should not be merged until the code changes are properly included.

About this PR

  • The PR claims to include miscellaneous bug fixes in the parser, semantic analyzer, and transpiler, but without a diff, the scope and impact of these fixes cannot be evaluated.
  • The PR description mentions the addition of 'new unit-tests', but no test files or modifications were included in the diff.
  • The PR contains no code changes. The implementation of the char type, CharLiteral AST node, and various bug fixes mentioned in the description are missing from the submission.

Test suggestions

  • Parsing of valid UTF-8 character literals
  • Validation of multi-byte UTF-8 characters within a char literal
  • Semantic analysis and type-checking of char types
  • Transpilation of char types to the target language
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Parsing of valid UTF-8 character literals
2. Validation of multi-byte UTF-8 characters within a char literal
3. Semantic analysis and type-checking of char types
4. Transpilation of char types to the target language

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@chadsec1
chadsec1 merged commit 4570337 into main Jul 13, 2026
7 of 8 checks passed
@chadsec1
chadsec1 deleted the feat/char-type-and-string-manipulation branch July 14, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant