[AI] What to change: The dp icon for a specific registered user (user means all us... - #195
Open
burkongla wants to merge 1 commit into
Open
Conversation
…r means all us... Task: d8d55d4c Source: slack Requested by: U04E9DZ5ELF
✅ Deploy Preview for githelp-support ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR
Task: What to change: The dp icon for a specific registered user (user means all us...
Description: What to change: The dp icon for a specific registered user (user means all user groups)
Description and specific values:
• Make sure that the color of the dp icon for a specific user is consistent across all usage contexts. Currently the color of the dp icons changes when you navigate from “List of helpers” into “See profile” within the Helpers page, for Admin. The color shown in the list is different from the color shown in the profile. The color must be the same regardless of context. If a user is registered within multiple user categories, make sure that the color of the dp icon for that specific user, is consistent across all categories (User, Helper, Admin) and pages.
Do not change: Anything else than what is listed.
Acceptance criteria: When all points listed under “Description and specific values” are implemented the task is done.
Source: slack
Requested by: U04E9DZ5ELF
Classification: flow
Changes
Avatar fallback colors are derived deterministically from an id via getAvatarColorHexForId, but different pages key the same person on different ids (helper_id vs user_id vs name), causing the color to change between the Helpers list and the helper profile (and elsewhere). Normalize every avatar color lookup to key on the person's user_id first (falling back to helper_id only for unregistered helpers), so one user always gets one color across Admin/Helper/User contexts.
Security Review
Status: pass
No package.json/import_map changes, so no dependency audit was needed. The diff only threads
projects_helpers.user_id(already exposed to clients elsewhere, e.g. the helpers list page) into avatar-color derivation; no new XSS sinks, injection vectors, secrets, auth/CORS changes, or schema/RLS changes.avatarColorsafely accepts null/undefined, so the new nullableprimaryHelperAvatarKeyis handled.🤖 Generated by githelp-support agent team