Skip to content

Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with upcoming GMT 6.7.0 #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seisman wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −22
Open

Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with upcoming GMT 6.7.0 #4729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ab0ecb
Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with …
seisman Jul 17, 2026
2bd166e
Revert "Figure.directional_rose/Figure.magnetic_rose: Fix compatibili…
seisman Jul 17, 2026
badaee8
Figure.directional_rose/Figure.magnetic_rose: Fix compatibility with …
seisman Jul 17, 2026
fce1335
Set the default to TR
seisman Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions pygmt/src/directional_rose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
from collections.abc import Sequence
from typing import Literal

from packaging.version import Version
from pygmt._typing import AnchorCode
from pygmt.alias import Alias, AliasSystem
from pygmt.clib import Session, __gmt_version__
from pygmt.clib import Session
from pygmt.helpers import build_arg_list, fmt_docstring
from pygmt.params import Box, Position
from pygmt.src._common import _parse_position
Expand Down Expand Up @@ -84,15 +83,8 @@ def directional_rose(
"""
self._activate_figure()

# The default position is set to "TR" since GMT 6.7.0, which has no default value
# in GMT 6.6.0 and earlier versions.
# TODO(GMT>6.6.0): Set 'default=None' after GMT 6.7.0.
position = _parse_position(
position,
default=None
if Version(__gmt_version__) > Version("6.6.0")
else Position("TR", cstype="inside"),
)
# Set the default position to "TR" to be consistent with the behavior in GMT 6.7.0
position = _parse_position(position, default=Position("TR", cstype="inside"))

aliasdict = AliasSystem(
F=Alias(box, name="box"),
Expand Down
14 changes: 3 additions & 11 deletions pygmt/src/magnetic_rose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@
from collections.abc import Sequence
from typing import Literal

from packaging.version import Version
from pygmt._typing import AnchorCode
from pygmt.alias import Alias, AliasSystem
from pygmt.clib import Session, __gmt_version__
from pygmt.clib import Session
from pygmt.exceptions import GMTParameterError
from pygmt.helpers import build_arg_list, fmt_docstring
from pygmt.params import Box, Position
Expand Down Expand Up @@ -109,15 +108,8 @@ def magnetic_rose( # noqa: PLR0913
"""
self._activate_figure()

# The default position is set to "TR" since GMT 6.7.0, which has no default value
# in GMT 6.6.0 and earlier versions.
# TODO(GMT>6.6.0): Set 'default=None' after GMT 6.7.0.
position = _parse_position(
position,
default=None
if Version(__gmt_version__) > Version("6.6.0")
else Position("TR", cstype="inside"),
)
# Set the default position to "TR" to be consistent with the behavior in GMT 6.7.0
position = _parse_position(position, default=Position("TR", cstype="inside"))

if declination_label is not None:
if declination is None:
Expand Down
Loading