Runtime library refactor - #104
Closed
RavenZhou07 wants to merge 28 commits into
Closed
Conversation
This reverts commit 4616e39.
Member
|
Superseded by #106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an initial runtime library refactor for GenSym. The main goal is to start separating part of the GenSym runtime implementation from the generated C++ translation units, so that future work can move more runtime logic into independently compiled source files instead of repeatedly compiling everything through headers.
This is an initial step rather than a complete migration away from the current header-based runtime structure.
Changes
Added a new runtime library structure under runtime/.
Added runtime/include/gensym/runtime.hpp as the entry header for the runtime library.
Added runtime/src/runtime.cpp as the initial runtime source file.
Added runtime/src/defs.cpp to move part of the definitions out of the header-only path.
Updated headers/gensym/defs.hpp accordingly so that these definitions can be provided by the runtime source file instead of being fully defined in the header.