refactor: extract IBinaryDiffer to Core — fix PatchMiddleware circular dependency (#346) - #347
Merged
Merged
Conversation
…r dependency - Created IBinaryDiffer in Core (GeneralUpdate.Core.Differential namespace) - Differential's IBinaryDiffer now inherits from Core interface (backward-compat) - Added .BinaryDiffer<T>() extension point to AbstractBootstrap - PatchMiddleware now accepts IBinaryDiffer via constructor injection and performs real differential patching when a differ is provided - Without injection, PatchMiddleware gracefully skips with a log message Closes #346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates the circular dependency between Core and Differential by extracting
IBinaryDifferinto Core. PatchMiddleware now performs real differential patching when a differ is injected.Changes
New:
GeneralUpdate.Core.Differential.IBinaryDifferUpdated:
GeneralUpdate.Differential.Abstractions.IBinaryDifferIBinaryDiffer(backward compatible)Updated: AbstractBootstrap
.BinaryDiffer<T>()extension point for injecting IBinaryDiffer implementationsUpdated: PatchMiddleware
IBinaryDiffer?via constructor injectionDirtyAsync()Verification
dotnet build src/c#/GeneralUpdate.slnx— 0 errors, 0 warningsCloses #346