Skip to content

fix: restore Core project compilation — remove Compile Remove, fix API mismatches (#342) - #343

Merged
JusterZhu merged 1 commit into
masterfrom
fix/restore-core-compilation
May 24, 2026
Merged

fix: restore Core project compilation — remove Compile Remove, fix API mismatches (#342)#343
JusterZhu merged 1 commit into
masterfrom
fix/restore-core-compilation

Conversation

@JusterZhu

Copy link
Copy Markdown
Collaborator

Summary

Restores compilation for the entire \GeneralUpdate.Core\ project. Previously, all Bootstrap, Strategy, SilentUpdateMode, and Pipeline files were excluded via <Compile Remove>\ directives — only the abstract base layer compiled. Now the full project builds.

Changes

  • *Removed <Compile Remove>* for Bootstrap (GeneralUpdateBootstrap, GeneralClientBootstrap, GeneralUpdateOSS, GeneralClientOSS), all Strategies (Windows, Linux, OSS, Mac), SilentUpdateMode, and PatchMiddleware
  • PatchMiddleware rewritten as no-op stub — waits for T2 (IBinaryDiffer interface extraction) to resolve circular dependency with GeneralUpdate.Differential
  • MacStrategy fixed: .Use(new HashMiddleware())\ → .UseMiddleware()\ (matching PipelineBuilder API)
  • BlackListManager API mismatches fixed: \AddBlackFileFormats\ → \AddBlackFormats, \BlackFileFormats\ → \BlackFormats\ in Bootstrap and SilentUpdateMode callers
  • DrivelutionMiddleware remains excluded (requires net10.0; Core targets netstandard2.0)

Verification

  • \dotnet build src/c#/GeneralUpdate.slnx\ → 0 errors, 0 warnings across all 11 projects
  • All tests compile successfully

Closes #342

…I mismatches

- Removed Compile Remove directives for Bootstrap, Strategy, Silent,
  PatchMiddleware files (only DrivelutionMiddleware remains excluded)
- Rewrote PatchMiddleware as no-op stub (defers IBinaryDiffer injection
  to T2 to avoid circular dependency with GeneralUpdate.Differential)
- Fixed MacStrategy: Use() calls → UseMiddleware<T>()
- Fixed BlackListManager API: AddBlackFileFormats → AddBlackFormats,
  BlackFileFormats → BlackFormats
- Full solution builds with 0 errors 0 warnings

Closes #342
Copilot AI review requested due to automatic review settings May 24, 2026 07:50
@JusterZhu
JusterZhu merged commit 9a25ce7 into master May 24, 2026
1 check failed
@JusterZhu
JusterZhu deleted the fix/restore-core-compilation branch May 24, 2026 07:51
@JusterZhu
JusterZhu removed the request for review from Copilot May 24, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T1: Restore Core project compilation — fix Compile Remove, Hub compat, and build errors

1 participant