fix: restore Core project compilation — remove Compile Remove, fix API mismatches (#342) - #343
Merged
Merged
Conversation
…I mismatches - Removed Compile Remove directives for Bootstrap, Strategy, Silent, PatchMiddleware files (only DrivelutionMiddleware remains excluded) - Rewrote PatchMiddleware as no-op stub (defers IBinaryDiffer injection to T2 to avoid circular dependency with GeneralUpdate.Differential) - Fixed MacStrategy: Use() calls → UseMiddleware<T>() - Fixed BlackListManager API: AddBlackFileFormats → AddBlackFormats, BlackFileFormats → BlackFormats - Full solution builds with 0 errors 0 warnings Closes #342
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores compilation for the entire \GeneralUpdate.Core\ project. Previously, all Bootstrap, Strategy, SilentUpdateMode, and Pipeline files were excluded via <Compile Remove>\ directives — only the abstract base layer compiled. Now the full project builds.
Changes
Verification
Closes #342