Performance improvements#9
Open
aboroska wants to merge 5 commits into
Open
Conversation
legoscia
approved these changes
Feb 3, 2022
legoscia
left a comment
legoscia
left a comment
There was a problem hiding this comment.
Seems like Erlang 21 has bitrotted in Travis. We should probably replace it with some newer versions in .travis.yml.
The default value in dict:update/4 is not wrapped in a fun and evaluated each time. That caused double timestamp calls when a metric was already added. To make things worse this was called for each inserted metric in every second.
As the window is not changing runtime, no need to keep the last 5 minutes of metrics. Keeping 300 elements in a list for each metric puts extra burden on the lists and dict functions in the statman_aggregator module. A 30 seconds window now makes the aggregator to keep 30 samples only.
aboroska
force-pushed
the
fix-insert-timestamp-purge-size
branch
from
141d77f to
a0a6ae7
Compare
velimir
approved these changes
Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dead code
Reduce number of timestamp calls
The default value in dict:update/4 is not wrapped in a fun and evaluated
each time. That caused double timestamp calls when a metric was already
added. To make things worse this was called for each inserted metric
in every second.
Reduce memory usage of aggregator
As the window is not changing runtime, no need to keep the last 5
minutes of metrics.
Keeping 300 elements in a list for each metric puts extra burden on the
lists and dict functions in the statman_aggregator module.
A 30 seconds window now makes the aggregator to keep 30 samples only.