fix(mobile): trigger OTA publishes for shared changes - #141
Merged
Conversation
Owner
Author
|
Local proof from 3de4494: the regression test confirms shared-package and lockfile changes trigger the OTA workflow, while release-helper-only changes do not.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mobile OTA workflow now publishes when the shared package or lockfile changes, and skips release-helper-only changes.
Details
apps/shared/**with the realpackages/shared/**path.pnpm-lock.yaml, since transitive dependency changes can alter the mobile bundle..github/scripts/**.Testing steps
python3 -m unittest discover -s .github/scripts -p 'test_release.py' -vThe output should show the mobile publish path test as
ok, and the command should exit successfully.