[BUG] Fixed (and refactored) geometry refiner#373
Open
najlkin wants to merge 8 commits into
Open
Conversation
This reverts commit f5b5205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed geometry refiner settings, which was not correctly passed to the worker threads as reported by @v-dobrev . This was to great extent a problem of the poor design of the shared global object. This PR refactors the codebase, moving the
GeometryRefinerto the base classVisualizationSceneScalarData, where it is available to all visualization scenes. The type of the refiner is set inDataStatealong other settings. Moreover, passing of this kind of parameters has been refactored out fromGLVisServeras the list was growing and growing 😳 .