fix(ui): replace the logo with the transparent-background version - #332
Merged
Conversation
public/gdg-logo.png tenía el fondo blanco calcado en el propio PNG (RGBA totalmente opaco en las cuatro esquinas), así que sobre cualquier superficie que no fuese blanca se veía como un recuadro claro. Salta a la vista en el panel, que es oscuro: el logo aparece metido en una caja. Se sustituye por la versión que ya venía preparada en la rama del rediseño (worktree-redesign-ux, PR #278): fondo transparente y 180x180 en vez de 120x120. El archivo se referencia desde diez sitios, todos con <img> y clases o atributos que solo escalan —ninguno usa el componente Image de Astro—, así que el cambio de dimensiones no afecta a ningún layout. Las esquinas redondeadas del footer y de /about estaban ahí para disimular el recuadro blanco; ahora son inocuas, no las toco para no mezclar cambios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
public/gdg-logo.pngis replaced with the version already prepared on the redesign branch (worktree-redesign-ux, #278).Why
The old PNG had the white background baked into the image — all four corners are fully opaque RGBA
(255,255,255,255). On any surface that is not white, the logo renders as a light box instead of a logo. It is most obvious in the admin panel, which is dark:The corrected asset already existed on the redesign branch, so this pulls just that one file rather than waiting for the whole redesign PR to land.
Notes for review
<img>with CSS classes orwidth/heightattributes that only scale it — none use Astro's<Image>component, so nothing does build-time processing against the old dimensions. Going from 120px to 180px is safe, and the larger source is an improvement for theog:image/ JSON-LDlogoreferences.rounded-sm(Footer) androunded-2xl(/about) classes on the logo were there to soften the white box. They are harmless now that there is no box, but I left them alone rather than mix an unrelated cleanup into an asset swap.public/favicon.pngis also upgraded on feat(ui): redesign public site with design system, dark mode and a11y fixes #278 (64×64 → 128×128). I did not include it here since the request was specifically the logo — say the word and I will add it to this PR.How to test
Visually, the place it matters most is the dark UI: open
/admin(sidebar) and the login screen, and confirm the logo no longer sits inside a white square. Also check the footer and/about, which render it on light backgrounds — it should look unchanged there.