fix(session): harden cross-surface persistence and ACP lifecycle#1621
Merged
limityan merged 1 commit intoJul 19, 2026
Merged
Conversation
limityan
force-pushed
the
yanzhn/session-continuity-acp-lifecycle
branch
from
July 19, 2026 00:42
8ca69ae to
5054c6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Product and architecture boundaries
session/closeonly releases active ACP/Core/MCP resources and retains reloadable historyEnd-to-end behavior
Validation
Independent architecture, product-design, and reliability reviewers adversarially reviewed the final tree. All P0/P1/P2 findings and wording-level follow-ups were addressed before submission.
cargo check --workspacecargo test -p bitfun-core- 1211 passed, 1 ignoredcargo test -p bitfun-cli- 256 unit tests plus ACP stdio, exec, plugin, product-assembly, and PTY/ConPTY contracts passedcargo test -p bitfun-acp --lib- 101 passedcargo test -p bitfun-desktop- 110 passedcargo test -p bitfun-services-integrations --features mcp- 12 unit and 35 MCP contract tests passedpnpm --dir src/web-ui run test:run- 261 files / 1626 tests passedpnpm run lint:web- 0 errors; 12 unchanged warningspnpm run type-check:webnode scripts/check-core-boundaries.mjsgit diff --check gcwing/main --A prior full
cargo test --workspace --no-fail-fastsweep exposed one unchanged Windows extended-path-prefix assertion outside this PR. The affected changed packages and MCP contracts pass in the final isolated runs above.