Remove curl_close calls - #79
Open
michalfelski wants to merge 2 commits into
Open
Conversation
Add a PHP >=8.0 requirement to composer.json. Remove explicit curl_close($curl) calls from RESTClient.php as it has no efect and produces warning
There was a problem hiding this comment.
Pull request overview
Removes obsolete curl_close() calls and raises the minimum PHP version to 8.0.
Changes:
- Removed explicit cURL handle cleanup.
- Added PHP
>=8.0Composer requirement. - Regenerated
composer.lockis still required.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary |
|---|---|
src/FusionAuth/RESTClient.php |
Removes obsolete cURL cleanup calls. |
composer.json |
Declares PHP 8.0 minimum; composer.lock must be regenerated to match. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| ], | ||
| "require": { | ||
| "php": ">=8.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes explicit curl_close($curl) calls from RESTClient.php.
In PHP 8.0 and later, cURL handles are represented by CurlHandle objects instead of resources. As a result, curl_close() no longer has any effect. Starting with PHP 8.5, calling curl_close() also triggers a deprecation warning.
Before PHP 8.0, curl_close() was still required to explicitly close cURL resources. Since removing these calls drops compatibility with PHP versions older than 8.0, the minimum PHP requirement for this package has been updated to PHP 8.0.