Update workflows - #2
Merged
Merged
Conversation
Bonajo
commented
Oct 27, 2025
Bonajo
commented
Contributor
- Update workflows to reusable workflow
- Rename artifacts for new naming scheme on maven central
- Add instruction in readme
lenntt
approved these changes
Oct 27, 2025
| <version>2.5</version> | ||
| <groupId>io.github.fontysvenlo</groupId> | ||
| <artifactId>alda_simpletime_api</artifactId> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
fair enough, works due to the rename, but confusing maybe?
should we 'unpublish'the https://mvnrepository.com/artifact/io.github.fontysvenlo.alda/simpletime_api artefacts?
Contributor
Author
There was a problem hiding this comment.
True, but I think we can start with a nice version now with the new naming scheme. Especially as before we didn't follow semantic versioning.
Deleting is certainly an option, lets discuss with @RvandenHam as well
| branch: javadoc | ||
| target-folder: ${{ env.TAG_VERSION }} | ||
| deploy: | ||
| uses: FontysVenlo/alda_api_workflows/.github/workflows/deploy.yml@main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.