Skip to content

feat: add icon for settings and theme#163

Merged
paodb merged 1 commit into
masterfrom
more-icons
Jul 21, 2026
Merged

feat: add icon for settings and theme#163
paodb merged 1 commit into
masterfrom
more-icons

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added Settings and Theme icons to the Commons Demo icon set.
    • The new icons are available for use throughout the interface.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

Demo icon additions

Layer / File(s) Summary
Icon names and SVG assets
base/src/main/java/com/flowingcode/vaadin/addons/demo/CommonsDemoIcons.java, base/src/main/resources/META-INF/resources/frontend/commons-demo-iconset.ts
The public enum adds SETTINGS and THEME, and the commons-demo iconset registers matching settings and theme SVG entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: adding settings and theme icons.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch more-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@javier-godoy
javier-godoy requested review from paodb and scardanzan July 21, 2026 13:11
@javier-godoy
javier-godoy marked this pull request as ready for review July 21, 2026 13:11
@paodb
paodb merged commit 69a4e6d into master Jul 21, 2026
3 checks passed
@paodb
paodb deleted the more-icons branch July 21, 2026 13:36
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants