Skip to content

feat: add icons for light and dark mode#162

Merged
paodb merged 1 commit into
masterfrom
feat-color-scheme-icons
Jul 20, 2026
Merged

feat: add icons for light and dark mode#162
paodb merged 1 commit into
masterfrom
feat-color-scheme-icons

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added light mode and dark mode icons to the demo icon set.
    • The new icons are available for use alongside the existing demo icons.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The demo icon enum now exposes DARK_MODE and LIGHT_MODE, and the frontend iconset template defines matching sun and moon SVG glyphs.

Changes

Iconset expansion

Layer / File(s) Summary
Icon declarations and SVG glyphs
base/src/main/java/com/flowingcode/vaadin/addons/demo/CommonsDemoIcons.java, base/src/main/resources/META-INF/resources/frontend/commons-demo-iconset.ts
The public enum adds dark- and light-mode names, while the SVG template adds corresponding moon and sun glyph definitions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: adding light and dark mode icons.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-color-scheme-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@javier-godoy
javier-godoy marked this pull request as ready for review July 20, 2026 14:41
@javier-godoy
javier-godoy requested review from paodb and scardanzan July 20, 2026 14:42
@paodb
paodb merged commit 61de2c5 into master Jul 20, 2026
3 checks passed
@paodb
paodb deleted the feat-color-scheme-icons branch July 20, 2026 15:14
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants