fix(proof): preserve sparse reads and relation integrity - #249
Merged
Conversation
Treat missing collection directories as empty while keeping other I/O errors on the normal rejection path. Remove the async Promise executor that could leave callers waiting after a source failure. Validate derives_from targets before the journal writes. Report missing targets in legacy relation data with PROOF_DANGLING_RELATION instead of returning a partial success. Cross-effort relation behavior stays unchanged. Tests: corepack pnpm exec ava packages/source-filesystem/src/utils/tests/gatherFileNodes.test.ts packages/source-filesystem/src/utils/tests/fetch.test.ts packages/proof/src/__tests__/planner.test.ts packages/flatbread/src/cli/proof.test.ts Tests: corepack pnpm verify Fixes FlatbreadLabs#248 Change-Id: I280e994847b1554cbdbd9c5779d5ca223a4983c1
toeknee-figma
marked this pull request as ready for review
August 15, 2026 22:04
tonyketcham
enabled auto-merge
August 15, 2026 22:23
tonyketcham
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat missing collection directories as empty while keeping other I/O errors on the normal rejection path. Remove the async Promise executor that could leave callers waiting after a source failure.
Validate derives_from targets before the journal writes. Report missing targets in legacy relation data with PROOF_DANGLING_RELATION instead of returning a partial success. Cross-effort relation behavior stays unchanged.
Tests: corepack pnpm exec ava packages/source-filesystem/src/utils/tests/gatherFileNodes.test.ts packages/source-filesystem/src/utils/tests/fetch.test.ts packages/proof/src/tests/planner.test.ts packages/flatbread/src/cli/proof.test.ts
Tests: corepack pnpm verify
Fixes #248
Change-Id: I280e994847b1554cbdbd9c5779d5ca223a4983c1