Skip to content

ci: add manifest-declared mixed nightly profiles - #154

Open
galargh wants to merge 6 commits into
mainfrom
galargh/nightly-mixed-test-profiles
Open

ci: add manifest-declared mixed nightly profiles#154
galargh wants to merge 6 commits into
mainfrom
galargh/nightly-mixed-test-profiles

Conversation

@galargh

@galargh galargh commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Related to #121

This expands the concept of test profiles introduced in #128 to cover partial upgrade nightly testing profiles. In those, all the components but one are taken from the stability profile while the one that is supposed to get upgraded is taken from frontier.

The way in which I propose introducing this feature makes it easy to create any such combination. In particular, I think we might be interested in adding testing profiles that take most of the components from frontier while one lags behind from stability, for example.

Testing

@FilOzzy FilOzzy added this to FOC Jul 16, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Jul 16, 2026
@galargh
galargh force-pushed the galargh/nightly-mixed-test-profiles branch from da076d6 to 11ea0cc Compare July 27, 2026 18:58
@galargh galargh changed the title Add manifest-declared mixed nightly profiles ci: add manifest-declared mixed nightly profiles Jul 27, 2026
@galargh
galargh marked this pull request as ready for review July 29, 2026 20:05
@galargh
galargh requested review from BigLep, rjan90 and rvagg July 29, 2026 20:05
@galargh galargh self-assigned this Jul 29, 2026
@rjan90 rjan90 moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Jul 30, 2026
@rjan90 rjan90 moved this from ✔️ Approved by reviewer to 🔎 Awaiting review in FOC Jul 30, 2026
Comment thread ci/dependency-profiles.json

@rvagg rvagg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, not a deep review but this seems neat and I'd like to see it in action

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends foc-devnet’s CI dependency profile system to support manifest-declared “mixed” nightly profiles (partial-upgrade legs), where most components resolve from a base profile (e.g., stability) while one component resolves from another (e.g., frontier). It updates the dependency resolver and nightly workflow matrix accordingly, and adds support for pinning PDP via a git submodule gitlink.

Changes:

  • Introduces a v2 dependency manifest schema with a top-level profiles map, enabling mixed profiles like stability-frontier-curio.
  • Extends the resolver with profile validation/mapping and a new git_submodule strategy (used to pin PDP from a filecoin-services tag’s submodule gitlink).
  • Expands nightly CI matrix legs and updates docs/tests/renovate config to match the new behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/tests/test_resolve_ci_dependencies.py Adds helper builders and expands unit coverage for mixed profiles and git_submodule resolution.
scripts/resolve-ci-dependencies.py Implements manifest schema v2 (profiles), profile validation/mapping, selection_profile metadata, and git_submodule support via gitlink reading.
renovate.json Adds a Renovate regex manager to update git_submodule tag pins in ci/dependency-profiles.json.
README_ADVANCED.md Documents mixed profiles and clarifies PDP pinning behavior in stability/frontier/mixed profiles.
ci/README.md Documents manifest-declared profiles, mixed profile semantics, and the new git_submodule strategy.
ci/dependency-profiles.json Bumps schema to v2, declares mixed profiles, and changes pdp.stability to git_submodule pinned from filecoin-services tag v1.3.0.
.github/workflows/ci_run.yml Updates reusable workflow input descriptions to reflect manifest-declared profiles (including mixed).
.github/workflows/ci_nightly.yml Expands nightly matrix to include the new mixed profiles.

Comment thread ci/dependency-profiles.json

@rjan90 rjan90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I noticed the mixed-profile labels referenced in ci_nightly.yml did not exist yet, so I created the four corresponding scenarios-run-stability-frontier-* labels before approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✔️ Approved by reviewer

Development

Successfully merging this pull request may close these issues.

5 participants