Conversation
…cumentation, except those for the default class
…o be returned when an error is triggered
…permissions associated to their account, instead of having a specific username like admin or auditor
…filter users, based on their permissions
…ic for opal, so it returns an empty tibble if not records are found
…mentations for the opal class
… the new_safe_symbol internal helper
…ogs. Add code to convert list of calls into tibble
…registry), which now takes a timestamp, session and user to match a symbol in a function call.
…/source table/resource when argument is masked by an assignment operation
…r, resolve_symbol_asset
…underlying function package is not installed on the audit server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dsROCrate 0.2.0
Breaking Changes
safe_output()no longer includes atablecolumn. It has been replaced by three more granular columns:kind(whether the tracked object is atable,resourceorexpression),asset(the resolved table/resource name) andexpr(the associated R expression, when applicable). Code that reads thetablecolumn directly will need to be updated.New Features
safe_symbol(),safe_call(),safe_reference(),symbol_registry()) that replaces regex-based parsing of Opal logs, modelling assignments and aggregate function calls as objects and resolving arguments back to the symbols/tables they reference.backend_logs(),backend_options(),backend_users(),backend_projects(),backend_sys_perms(), and others) so internal code no longer callsopalr::directly, paving the way for additional backends.check_permissions(),init(),report(),safe_data(),safe_output(),safe_people()andsafe_setting()now all haveArmadilloCredentialsmethods, returning clear "not yet implemented" errors ahead of full support.defaultS3 methods foraudit(),audit_engine()andcheck_permissions(), giving clearer errors when an unsupported connection object is supplied.verboseargument tocheck_permissions()(opal method) to optionally print a success message when permissions are sufficient.print.safe_call()andprint.safe_symbol()methods, plusas.data.frame()methods forsafe_callandsymbol_registryobjects, for readable inspection of the new internal tracking objects.Improvements
safe_people()now determines admin/auditor status from actual system permissions and group membership, rather than a hardcoded name check against"admin"/"administrator", improving compatibility with deployments that use differently named privileged accounts.safe_people()now fall back gracefully to an empty result instead of aborting the whole audit.Documentation
init(),safe_data(),report()and related functions now accept eitheropalorArmadilloCredentialsconnections.Internal Changes
audit(),audit_engine()andcheck_permissions(), along with a mock-connection test helper, reducing reliance on a live demo Opal server.uuidtoImports, used to generate unique IDs for tracked symbols.testthatversion requirement inSuggestsfrom>= 3.0.0to>= 3.1.4.