fix(rp): reacquire same-name CDC after BOOTSEL deploy - #1405
Draft
zackees wants to merge 1 commit into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A phantom COM record such as
COM18was counted as already present before an RP2350 UF2 flash. When the board returned healthy onCOM18, post-flash discovery filtered it out solely because its name had not changed, so deploy returned no application port and AutoResearch could not continue.Validation
bash test -p fbuild-deploy— 288 passed, 13 ignoredsoldr cargo fmt --all -- --checksoldr cargo clippy -p fbuild-deploy --all-targets -- -D warningsbash testCloses #1404
Coordinated with FastLED/FastLED#4062.