Fix math module crash and lock file descriptor leak - #1
Open
IovAnto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes crashes and instance-locking issues in the math module.
Key changes:
Fix "Instance already running": Added O_CLOEXEC to the lock file to prevent background child processes (like wl-copy) from keeping the application locked after exit.
Fix Crashes: Added safety checks for popen results to prevent Segfaults if qalc fails or is missing.
Code Cleanup: Replaced unsafe strncat with snprintf, fixed a logic fallthrough in module execution, and stripped trailing newlines from calculator results.