pre-1stflight: link the ExpressLRS Telemetry Widget - #556
Draft
MUSTARDTIGERFPV wants to merge 1 commit into
Draft
Conversation
Closes ExpressLRS#419. The widget is an official ExpressLRS project but the site never mentions it. A search of the whole docs tree for "telemetry widget", "ElrsTelem" or "TelemWidget" returns nothing. The natural place is right after sensor discovery on the first flight page, since that is when the user has just built the sensor list and is looking at the telemetry screen. Contents come from the widget README: the WIDGETS/ELRST install path, the need to discover sensors before adding the widget, the restart if that order is missed, the expected sensor counts of 17 for Betaflight and 23 for iNav with GPS, and the ELRSb, ELRSu and ELRSt function scripts. The README gives its tested configuration as a TX16S on EdgeTX 2.5 and there is no newer compatibility statement, so the note repeats that as written and sends bug reports to that repository rather than implying support for later handsets that has not been verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #419.
ElrsTelemWidget is an official ExpressLRS project, but the site never mentions it. Grepping the whole docs tree for
telemwidget,telemetry widgetorElrsTelemreturns zero hits.Issue #419 asks for it to be surfaced during first time setup, so this adds a subsection to the Telemetry section of the first flight page, immediately after sensor discovery. That is the moment the user has just built their sensor list and is looking at the telemetry screen, so it is the point where the widget is most useful.
Content
Everything is taken from the widget README rather than invented:
src/WIDGETS/ELRSTintoWIDGETS/so the card holdsWIDGETS/ELRST/main.luaELRSb.lua,ELRSu.luaandELRSt.luafunction scripts for binding from a switchCompatibility statement
The README still says "Tested on Radiomaster TX16S with EdgeTX 2.5 only" and there is no newer statement anywhere in the repository. Rather than paper over that, the note repeats it as written and points bug reports at the widget repository. I did not claim it works on current handsets or current EdgeTX, because I have no way to verify that.
A current compatibility matrix would be a good follow up, but it needs someone with the hardware to test rather than a docs change.