lua-howto: document the Administered bind storage mode - #549
Draft
MUSTARDTIGERFPV wants to merge 1 commit into
Draft
lua-howto: document the Administered bind storage mode#549MUSTARDTIGERFPV wants to merge 1 commit into
MUSTARDTIGERFPV wants to merge 1 commit into
Conversation
The Bind Storage section listed Persistent, Volatile and Returnable but not Administered, which has shipped since 3.5.4. It is the fourth entry in the Lua selection and in the WebUI binding panel. Administered is enforced in EnterBindingMode(), which returns early when it is selected. Every route into bind mode goes through that function, so the Enter Bind Mode command, the bind button action, the three power cycle method, and the automatic bind of an unbound receiver are all blocked. The WebUI path is not gated, so it stays the only way to change the binding. Add a warning for the lockout case. An unbound receiver set to Administered will not bind over the air, so the WebUI has to be reachable or the receiver needs a UART re-flash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bind Storage section lists Persistent, Volatile and Returnable, but not Administered. It is the fourth entry in the Lua selection (
RXParameters.cpp,"Persistent;Volatile;Returnable;Administered") and in the WebUI binding panel, and it has shipped since 3.5.4.What it does
Enforcement is in one place,
EnterBindingMode()inrx_main.cpp:Every route into bind mode goes through that function, so all of these are blocked:
GetPowerOnCounter() >= 3!OtaUidIsBound(UID)Enter Bind ModecommandRXEndpoint.cppviaEnterBindingModeSafely()registerButtonFunction(ACTION_BIND, ...)The WebUI path is not gated.
devWIFI.cpponly tests bind storage for Volatile and Returnable, so the WebUI remains the only way to change the binding.The warning
An unbound receiver set to Administered will not bind over the air either, because the automatic bind path also goes through
EnterBindingMode(). Recovery is the WebUI, or a UART re-flash if the WebUI cannot be reached. The added warning says so and suggests setting a Home WiFi network first.Version
git tag --containson both the originalBINDSTORAGE_PERMANENTcommit and the later rename toBINDSTORAGE_ADMINISTEREDreturns 3.5.4 as the first release containing them.