Widen dependency versions - #64
Conversation
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| deps: |
There was a problem hiding this comment.
Ideally you'd want to add different PHP versions to this as well. I'll leave that out of scope for this PR though.
There was a problem hiding this comment.
Not sure why there were no workflows triggered for this PR though, the file syntax seems ok and I don't see any errors in the actions tab.
| use Psr\Http\Client\ClientExceptionInterface; | ||
| use Psr\Http\Client\ClientInterface; | ||
| use Psr\Http\Message\RequestFactoryInterface; | ||
| use Teapot\StatusCode\RFC\RFC7231; |
There was a problem hiding this comment.
Having a dependency just for readable http status codes, and enforcing that on all who install this library seems a bit wasteful. But if you insist on keeping this I can revert this, although in that case I would suggest using symfony/http-foundation as it's a far more common dependency.
|
@aarsilv you seem to be the most active maintainer here, could you take a look at this please? |
1 participant
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
We're using Eppo with this library and want to upgrade to Symfony 8. Currently the cache dependency is preventing that.
Description
I've widened the requirement for this dependency, and fixed some low-hanging fruit I encountered while doing so:
composer.lockas it's not recommended for librariesHow has this been documented?
How has this been tested?
make test