Skip to content

Fix LicenseItem ordering consistency - #96

Merged
Jake-Shadle merged 2 commits into
EmbarkStudios:mainfrom
floze-the-genius:fix/license-item-ordering
Aug 6, 2026
Merged

Fix LicenseItem ordering consistency#96
Jake-Shadle merged 2 commits into
EmbarkStudios:mainfrom
floze-the-genius:fix/license-item-ordering

Conversation

@floze-the-genius

Copy link
Copy Markdown
Contributor

Summary

  • make LicenseItem::PartialOrd and PartialEq agree with its existing Ord implementation
  • keep Licensee's intentional cross-type matching behavior, including ignoring a requirement's or_later flag
  • add representative table/property regressions for comparison consistency, symmetry, and transitivity
  • update the current-stable clippy expression needed by the repository's strict lint job

The fix enforces the documented ordering laws independently of whether the proposed rustc derive optimization ships.

Testing

  • Rust 1.97.1: cargo test --all-features
  • Rust 1.97.1: cargo clippy --all-targets --all-features -- -D warnings
  • Rust 1.85.0 MSRV: cargo check --all-targets --all-features
  • Rust 1.85.0 MSRV: cargo test --lib
  • Rust 1.98.0-beta.5: cargo test --all-features
  • Rust 1.98.0-beta.5: cargo clippy --all-targets --all-features -- -D warnings

Closes #95.

@Jake-Shadle Jake-Shadle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jake-Shadle
Jake-Shadle self-requested a review August 6, 2026 14:16
@Jake-Shadle
Jake-Shadle merged commit 744e4cd into EmbarkStudios:main Aug 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-canonical impl of PartialOrd for LicenseItem breaks on rustc 1.98.0-beta.1

2 participants