Fix LicenseItem ordering consistency - #96
Merged
Jake-Shadle merged 2 commits intoAug 6, 2026
Merged
Conversation
Jake-Shadle
self-requested a review
August 6, 2026 14:16
Jake-Shadle
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LicenseItem::PartialOrdandPartialEqagree with its existingOrdimplementationLicensee's intentional cross-type matching behavior, including ignoring a requirement'sor_laterflagThe fix enforces the documented ordering laws independently of whether the proposed rustc derive optimization ships.
Testing
cargo test --all-featurescargo clippy --all-targets --all-features -- -D warningscargo check --all-targets --all-featurescargo test --libcargo test --all-featurescargo clippy --all-targets --all-features -- -D warningsCloses #95.