Optimize dropped-item section candidates#7
Draft
Arbousier1 wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SourceOwnedSectionCandidatesrollback switchIV_PERFWhy
The previous dropped-label path rebuilt global item/viewer structures every refresh. With per-viewer visibility enabled this scales toward players times all items and allocates transient lists, locations, spatial maps, and components even when no audience or pending visibility work exists.
Impact
The new path uses Paper's authoritative entity-section ownership and only processes items around eligible viewers. Visual distance, 16-block retention hysteresis, cramping, formatting, and token-bucket behavior remain unchanged. The new candidate source defaults to
falseuntil formal evidence passes; existing configurations are not migrated automatically.Validation
gradlew clean check shadowJar --no-daemon --no-build-cache --rerun-taskstotalRetained=0analyze-phase2-abba.ps1 -SelfTestgit diff --checkThe canonical Paper 26.1.2 formal 12-run ABBA is in progress. This PR must remain unmerged until the dropped-path CPU/MSPT gate and separate allocation/client checks are reviewed.
Paper 26.2 compatibility
Paper 26.2 removed the public NMS
EntityType.TEXT_DISPLAYstatic constant. The packet-only bridge now resolves Bukkit'sTEXT_DISPLAYthrough Paper'sCraftEntityType.bukkitToMinecraftconverter, which is present on both Paper 26.1.2-74 and 26.2-62. The regression fixture deliberately omits the old NMS field.Performance evidence is intentionally collected on one pinned runtime. Paper 26.2 remains covered by compilation and real startup/shutdown compatibility smoke, but is not part of the formal A/B matrix. The workflow and runtime harness now fix the benchmark version to Paper 26.1.2 and reject other values before preparation or server startup.