🐛 無効回転の赤枠を残して通知だけを止める - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
無効回転の赤枠を残してポップアップを停止
不正なCube回転を検出した際、赤い枠線は従来どおり表示し、エディタ上部のtoast通知だけを表示しないようにします。
主な変更
Blockbench.showToastNotificationの呼び出しと通知状態・定期監視処理を削除ERROR_OUTLINE_MATERIALとupdateCubeValidity(cube, false)の判定・適用経路を維持1.10.3へ上げ、changelogへ変更内容を追加設計判断
動作確認
yarn testyarn prodgit diff --check未対応・注意