feat: GUI domain selector with batched release evidence - #38
Merged
Conversation
Track B parity: the CLI has supported --domain since the inventory domain landed, but the GUI had no way to select it. Added a Domain selector (default refund), validated on the server like every other run option, and pushed through to the orchestrator. Also records the batched release evidence for the review-workspace, replay, integrator-example, settled-review, history/comparison, inventory, and extension-guide merges, including the pending run-lifecycle and replay-stdin entries, and distinguishes browser tests from component and orchestrator unit tests.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| const selectedResponse = url.searchParams.get("response") ?? "pass"; | ||
| const selectedFault = url.searchParams.get("fault") ?? "none"; | ||
| const selectedProve = url.searchParams.get("prove") ?? "simulate"; | ||
| const selectedDomain = url.searchParams.get("domain") ?? "refund"; |
There was a problem hiding this comment.
🟡 Duplicate domains bypass validation
A request with domain=refund&domain=payments passes because get() inspects only the first value. The server runs a refund instead of rejecting the unknown domain.
Suggested change
| const selectedDomain = url.searchParams.get("domain") ?? "refund"; | |
| const selectedDomains = url.searchParams.getAll("domain"); | |
| const selectedDomain = selectedDomains.length === 0 ? "refund" : selectedDomains.length === 1 ? selectedDomains[0] : null; |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capability
The GUI can now select the synthetic action domain (refund or inventory
allocation), matching the CLI's
--domain. Validated server-side with theother run options and rejected when unknown.
Also batches the release evidence pending since PRs #32/#33 with the
substantive merges since, and states explicitly that browser tests are a
separate evidence category from component and orchestrator unit tests.
Verification
npm test: 107/107 (2 new: selector presence/defaults and the inlinerequest shape; endpoint accepts inventory and rejects unknown domains).
npm run test:browser: 10/10, including a new real inventory journeyasserting its own policy reference (
aas-inventory-gate-v1), rail-reviewmode, and a recomputed digest match in the bindings panel.
npm run integrationunchanged and green.