Improve definitions and usage of "surface" vs "surface_adjacent_layer" for wind variables, as well as "direction" - #155
Open
mkavulich wants to merge 2 commits into
Open
Conversation
…rom_direction`, and update a few more missed variables containing "wind_at_surface"
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
grantfirl,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
July 23, 2026 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in issues #151 and #153, there are shortcomings in both the names and definitions surrounding near-surface wind. This PR implements the changes discussed in those issues:
wind_at_surfacevariables are nowwind_at_surface_adjacent_layerwind_to_directionin addition towind_from_directiondirectionis given a definition in the rulesIssues
Resolves #151, #153