fix(ci): lowercase the GHCR image name - #35
Merged
Conversation
Container registry names must be lowercase, but github.repository is EOEboh/hookdrop, so the first deploy failed at the build with "repository name must be lowercase". The name is now folded to lowercase when it is computed. The failure was harmless: the image is pushed before anything on the server is touched, so the running container was never involved.
Contributor
Deploying hookdrop-frontend with
|
| Latest commit: |
8d5d104
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6b3a9c7.hookdrop-frontend.pages.dev |
| Branch Preview URL: | https://fix-deploy-lowercase-image.hookdrop-frontend.pages.dev |
Contributor
Deploying hookdrop with
|
| Latest commit: |
8d5d104
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50ad7960.hookdrop.pages.dev |
| Branch Preview URL: | https://fix-deploy-lowercase-image.hookdrop.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix to the deploy workflow I added in #34.
github.repositoryisEOEboh/hookdrop, and container registry names must be lowercase, so the first run failed at build withrepository name must be lowercase.Harmless failure — the image is built and pushed before anything on the server is touched, so the running container was never involved and production stayed up throughout.
Merging this so the deploy path can actually be verified end to end.