feat: Epic #133 Japanese Workspace Enhancement - #156
Merged
Conversation
…alDate support, and celebration badge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #133, Resolves #134, Resolves #135, Resolves #136, Resolves #137, Resolves #138.
This PR implements the Japanese Workspace Enhancement epic.
Architectural Decisions & Module Mapping
The original spec proposed creating several new UI components (
ui/japaneseReviewModal.js,ui/flashcardView.js,ui/japaneseDashboardView.js). However, perAGENTS.md("Do not create duplicate owners for... review state, drawing state, or persistence"), I elected to integrate these directly into their existing canonical owners to avoid duplication:core/gamificationEngine.jsand stored atomically inSTORE_SETTINGSviacore/japaneseV2Storage.js(satisfyingcore/storage.jsrequirement).core/dailyGoals.jsand stored alongside Gamification. UI integrated directly into the existingrenderDashboardinui/japaneseApp.js.ui/japaneseApp.jsandstyles/japanese.cssusingdisplay: gridand 3D transforms.ui/kanjiInkView.jsto support Replay, high-res PNG export, and the Guidance placeholder.core/japaneseState.jsandcore/japaneseActions.jsby adding a configurablelimitrather than creating a duplicate state owner. UI buttons were appended toui/japaneseApp.js.Verification Evidence
All automated gates pass successfully:
Acceptance Criteria Mapping
<kbd>Space</kbd>to flip,<kbd>1-4</kbd>to rate.export.kanji-png), history traversal via Replay button.