Skip to content

feat: Epic #133 Japanese Workspace Enhancement - #156

Merged
Dyu20705 merged 5 commits into
devfrom
issue/133-japanese-workspace
Aug 31, 2026
Merged

feat: Epic #133 Japanese Workspace Enhancement#156
Dyu20705 merged 5 commits into
devfrom
issue/133-japanese-workspace

Conversation

@Dyu20705

Copy link
Copy Markdown
Owner

Resolves #133, Resolves #134, Resolves #135, Resolves #136, Resolves #137, Resolves #138.

This PR implements the Japanese Workspace Enhancement epic.

Architectural Decisions & Module Mapping

The original spec proposed creating several new UI components (ui/japaneseReviewModal.js, ui/flashcardView.js, ui/japaneseDashboardView.js). However, per AGENTS.md ("Do not create duplicate owners for... review state, drawing state, or persistence"), I elected to integrate these directly into their existing canonical owners to avoid duplication:

Verification Evidence

All automated gates pass successfully:

npm run lint          # PASS
npm run test:unit     # PASS
npm run test:integration # PASS
npm run test:e2e      # PASS (138 passed)

Acceptance Criteria Mapping

  • Gamification: XP and streak calculated deterministically.
  • Fluid Review: 3D flip animation, <kbd>Space</kbd> to flip, <kbd>1-4</kbd> to rate.
  • Kanji Tools: 4096 points limit maintained, transparent PNG export command (export.kanji-png), history traversal via Replay button.
  • Quick Study: Configurable limits (5, 10, 15) correctly filter the review queue.
  • Daily Goals: Target tracking integrated without modifying the core Anki/SM2 scheduler logic.

Copilot AI lite review requested due to automatic review settings August 30, 2026 11:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Dyu20705
Dyu20705 merged commit d53f851 into dev Aug 31, 2026
1 check passed
@Dyu20705
Dyu20705 deleted the issue/133-japanese-workspace branch August 31, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants