feat(editor): implement contextual floating markdown toolbar (#129) - #152
Merged
Conversation
) - Add core/markdownActions.js with pure text transformation helpers - Add ui/editorToolbar.js with accessible formatting buttons and keyboard navigation - Mount #editorToolbar above textarea in index.html with CSS token styling in editor.css - Wire toolbar action handling, selection sync, and editor commands in app.js - Add unit and E2E regression test suites
…ng, and lifecycle cleanup - P1-1: Remove Ctrl+I shortcut from editor.italic to preserve reservation for Issue #130 details inspector toggle - P1-2: Make link insertion naming truthful (Insert link placeholder) and remove modifier conflict with global command palette - P1-3: Explicitly document and model inline contextual toolbar architecture with strict selection synchronization - P1-4: Use named blur event handler and deterministically unregister all textarea/container listeners on destroy()
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Issue #129: Contextual Floating Markdown Toolbar as the first child package of Epic #128.
Changes
core/markdownActions.js):wrapSelection,insertBold,insertItalic,insertStrikethrough,insertInlineCode,insertLink,cycleHeading,insertTaskItemwith defensive copy and cursor/selection handling.ui/editorToolbar.js):index.html,editor.css):#editorToolbardirectly above#contentInputwithin the editor panel.--mn-*semantic token variables.app.js):Verification
npm run test:content: 3/3 passednpm run lint: 0 errorsnpm run test:unit: 283/283 passednpm run test:integration: 107/107 passednpm run test:perf: 4/4 passednpm run test:e2e: 124/124 passed (includingtests/e2e/editor-toolbar.spec.mjs)git diff --check: cleanCloses #129