fix: URL-encode logo paths in README for dark mode support - #9
Merged
Conversation
Replaces spaces in logo image paths with URL-encoded format to ensure proper loading in different environments. This change enhances the README's visual presentation.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 31. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
DrWheelicus
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dark mode logo in the README was not rendering on GitHub because the
srcsetattribute uses spaces as delimiters. The filenames (Transparent Logo Dark.png) contained spaces that broke the URL parsing.Fixed by URL-encoding spaces as
%20in the<picture>source paths.Type of Change
Checklist
How Has This Been Tested?