Skip to content

🔒 fix(service): secure Appium service TLS verification #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dor-bl wants to merge 3 commits into
base: master
Choose a base branch
from
Open

🔒 fix(service): secure Appium service TLS verification #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5be41a5
fix(service): add TLS verification to Appium service readiness check
Dor-bl Aug 10, 2026
4ca59e4
fix(service): secure Appium service TLS verification
Dor-bl Aug 10, 2026
e8d2d20
fix(ci): point flutter app URLs to v0.0.33 in functional tests
Dor-bl Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/functional-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ jobs:
XCODE_VERSION: 16.4
IOS_VERSION: 18.5
IPHONE_MODEL: iPhone 16
FLUTTER_ANDROID_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/latest/download/app-debug.apk"
FLUTTER_IOS_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/latest/download/ios.zip"
FLUTTER_ANDROID_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/download/0.0.33/app-debug.apk"
FLUTTER_IOS_APP: "https://github.com/AppiumTestDistribution/appium-flutter-server/releases/download/0.0.33/ios.zip"
PREBUILT_WDA_PATH: ${{ github.workspace }}/wda/WebDriverAgentRunner-Runner.app

steps:
Expand Down
12 changes: 11 additions & 1 deletion appium/webdriver/appium_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@

from selenium.webdriver.remote.remote_connection import urllib3

try:
import certifi

_ca_certs: Optional[str] = certifi.where()
except ImportError:
_ca_certs = None

DEFAULT_HOST = '127.0.0.1'
DEFAULT_PORT = 4723
STARTUP_TIMEOUT_MS = 60000
Expand Down Expand Up @@ -207,7 +214,10 @@ def is_service_listening(url: str, timeout: float = 5, custom_validator: Optiona
True if Appium server is running before the timeout
"""
time_started_sec = time.perf_counter()
conn = urllib3.PoolManager(timeout=1.0)
pool_kwargs: Any = {'timeout': 1.0, 'cert_reqs': 'CERT_REQUIRED'}
if _ca_certs:
pool_kwargs['ca_certs'] = _ca_certs
conn = urllib3.PoolManager(**pool_kwargs)
while time.perf_counter() < time_started_sec + timeout:
if custom_validator is not None:
custom_validator()
Expand Down
Loading