🧹 refactor: remove legacy fallback for device_time - #12
Conversation
Removes the legacy fallback mechanism in the `device_time` extension that relied on `UnknownMethodException` and `GET_DEVICE_TIME_GET` / `GET_DEVICE_TIME_POST` commands. It now directly uses `execute_script('mobile: getDeviceTime')`. Cleans up unneeded imports, constants, and the `CanRememberExtensionPresence` mixin. Updated the associated tests to remove obsolete HTTP mocks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removes the legacy fallback mechanism in the `device_time` extension that relied on `UnknownMethodException` and `GET_DEVICE_TIME_GET` / `GET_DEVICE_TIME_POST` commands. It now directly uses `execute_script('mobile: getDeviceTime')`. Cleans up unneeded imports, constants, and the `CanRememberExtensionPresence` mixin. Updated the associated tests to remove obsolete HTTP mocks.
Additionally fixes CI failures by pinning the flutter test app urls to the 0.0.33 release.
Removes the legacy fallback mechanism in the `device_time` extension that relied on `UnknownMethodException` and `GET_DEVICE_TIME_GET` / `GET_DEVICE_TIME_POST` commands. It now directly uses `execute_script('mobile: getDeviceTime')`. Cleans up unneeded imports, constants, and the `CanRememberExtensionPresence` mixin. Updated the associated tests to remove obsolete HTTP mocks.
Additionally fixes CI failures by pinning the flutter test app urls to the 0.0.33 release and increasing `androidInstallTimeout` for flutter tests.
|
Closing — no longer relevant against upstream ( Generated by Claude Code |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
🎯 What: Removed the legacy fallback mechanism (
try-exceptblock handlingUnknownMethodException) for retrieving device time inappium/webdriver/extensions/device_time.py, and updated associated tests. Cleaned up unusedGET_DEVICE_TIME_GETandGET_DEVICE_TIME_POSTendpoints.💡 Why: To improve code maintainability and readability by phasing out outdated appium server fallback logic and consistently using direct
mobile: getDeviceTimescript executions, aligning with modern Appium standards.✅ Verification: Verified by running the full test suite (
uv run pytest test/unit) andrufflinting checks to ensure code health is improved without behavioral regressions.✨ Result: A cleaner
DeviceTimeclass and mobile command constant list, directly leveragingmobile:execute script behaviors without legacy overhead.PR created automatically by Jules for task 15249938982603152128 started by @Dor-bl