Skip to content

🧹 refactor: remove legacy fallbacks for hw_actions extension - #11

Closed
Dor-bl wants to merge 3 commits into
masterfrom
refactor-hw-actions-remove-fallbacks-10425047002999956329
Closed

🧹 refactor: remove legacy fallbacks for hw_actions extension#11
Dor-bl wants to merge 3 commits into
masterfrom
refactor-hw-actions-remove-fallbacks-10425047002999956329

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Aug 10, 2026

Copy link
Copy Markdown
Owner

🎯 What: The code health issue addressed
Removed the try-except fallback blocks and dependency on CanRememberExtensionPresence for legacy mobile commands in HardwareActions (lock, unlock, is_locked, shake, finger_print).

💡 Why: How this improves maintainability
The fallback logic (e.g. assert_extension_exists and UnknownMethodException) for handling legacy endpoints that are being deprecated adds unnecessary bloat and complexity. Executing scripts with the mobile: prefix is the standard Appium way. Removing the fallbacks simplifies the code by removing branching logic.

Verification: How you confirmed the change is safe
Ran make unittest and verified that 173 tests pass. Updated lock_test.py, shake_test.py and fingerprint_test.py to use execute/sync mocks to verify the correct payload for the mobile scripts.

Result: The improvement achieved
A significantly cleaner hw_actions.py module with direct and performant execution of mobile extensions, decreasing overall complexity.


PR created automatically by Jules for task 10425047002999956329 started by @Dor-bl

Removed the legacy Appium extension presence checks and try-except fallbacks for `lock`, `unlock`, `is_locked`, `shake`, and `finger_print` in `HardwareActions`. The commands now exclusively rely on executing scripts with the `mobile:` prefix. Removed inheritance from `CanRememberExtensionPresence` and cleaned up tests to assert on the script execution endpoints.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Dor-bl added 2 commits August 10, 2026 06:33
Removed the legacy Appium extension presence checks and try-except fallbacks for `lock`, `unlock`, `is_locked`, `shake`, `finger_print`, `touch_id`, and `toggle_touch_id_enrollment` in `HardwareActions`. The commands now exclusively rely on executing scripts with the `mobile:` prefix. Removed inheritance from `CanRememberExtensionPresence` and cleaned up tests to assert on the script execution endpoints.
Update the functional-test.yml workflow to point to the specific 0.0.33 release instead of 'latest' because the latter is returning a 404 for the test applications.
@Dor-bl Dor-bl closed this Aug 10, 2026

Dor-bl commented Aug 10, 2026

Copy link
Copy Markdown
Owner Author

Closing — no longer relevant against upstream (appium/python-client). Current upstream appium/webdriver/extensions/hw_actions.py already has zero UnknownMethodException/CanRememberExtensionPresence fallback logic — it already matches this PR's target state exactly. This was covered by upstream's legacy-fallback removal effort (#1267).


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant