🧹 refactor: remove legacy fallbacks for hw_actions extension - #11
Conversation
Removed the legacy Appium extension presence checks and try-except fallbacks for `lock`, `unlock`, `is_locked`, `shake`, and `finger_print` in `HardwareActions`. The commands now exclusively rely on executing scripts with the `mobile:` prefix. Removed inheritance from `CanRememberExtensionPresence` and cleaned up tests to assert on the script execution endpoints.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removed the legacy Appium extension presence checks and try-except fallbacks for `lock`, `unlock`, `is_locked`, `shake`, `finger_print`, `touch_id`, and `toggle_touch_id_enrollment` in `HardwareActions`. The commands now exclusively rely on executing scripts with the `mobile:` prefix. Removed inheritance from `CanRememberExtensionPresence` and cleaned up tests to assert on the script execution endpoints.
Update the functional-test.yml workflow to point to the specific 0.0.33 release instead of 'latest' because the latter is returning a 404 for the test applications.
|
Closing — no longer relevant against upstream ( Generated by Claude Code |
🎯 What: The code health issue addressed
Removed the try-except fallback blocks and dependency on
CanRememberExtensionPresencefor legacy mobile commands inHardwareActions(lock,unlock,is_locked,shake,finger_print).💡 Why: How this improves maintainability
The fallback logic (e.g.
assert_extension_existsandUnknownMethodException) for handling legacy endpoints that are being deprecated adds unnecessary bloat and complexity. Executing scripts with themobile:prefix is the standard Appium way. Removing the fallbacks simplifies the code by removing branching logic.✅ Verification: How you confirmed the change is safe
Ran
make unittestand verified that 173 tests pass. Updatedlock_test.py,shake_test.pyandfingerprint_test.pyto useexecute/syncmocks to verify the correct payload for the mobile scripts.✨ Result: The improvement achieved
A significantly cleaner
hw_actions.pymodule with direct and performant execution of mobile extensions, decreasing overall complexity.PR created automatically by Jules for task 10425047002999956329 started by @Dor-bl