Skip to content

Create supdesk.app.portal.json for portal settings - #1502

Open
alexrabin wants to merge 2 commits into
Domain-Connect:masterfrom
RabinApps:supdesk-portal
Open

Create supdesk.app.portal.json for portal settings#1502
alexrabin wants to merge 2 commits into
Domain-Connect:masterfrom
RabinApps:supdesk-portal

Conversation

@alexrabin

@alexrabin alexrabin commented Aug 1, 2026

Copy link
Copy Markdown

Add configuration for SupDesk customer portal

Description

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Online Editor test results

Editor test link(s):
Test supdesk.app/portal example.com/feedback

Add configuration for SupDesk customer portal
@github-actions github-actions Bot added the hostRequired hostRequired is set label Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Linter OK

supdesk.app.portal.json

Level Code Note

Removed the 'providerDisplayName' field from the configuration.
@github-actions github-actions Bot added Test links missing No test links from Online Editor provided automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. labels Aug 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter passed all checks — approving for auto-merge.

@alexrabin alexrabin changed the title WIP: Create supdesk.app.portal.json for portal settings Create supdesk.app.portal.json for portal settings Aug 1, 2026
@alexrabin
alexrabin marked this pull request as ready for review August 1, 2026 20:40
@github-actions github-actions Bot removed the Test links missing No test links from Online Editor provided label Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. hostRequired hostRequired is set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant