wpt: raise testharness timeouts to deflake heavy interpolation tests - #815
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WPT runs have been producing flaky
Timeout ⇄ Failflips (e.g. ~35 spurious status changes on #814), almost all in the heavy interpolation/parsing testharness suites (css/*/animations/*-interpolation.html,color-mixparsing,test_font_family_parsing.html,has-complexity.html).Root cause: the injected
testharnessreport.jssetstimeout_multiplier: 0.1, scaling testharness's internal 10s timeout down to 1s of wall-clock time — and these tests take ~0.6–1.2s of real script time even on an idle machine. Since timers are pumped in real time, the internal timeout races the test's own execution; on loaded CI machines the same tests fall on either side of 1s from run to run. They are not hangs: given budget, every one of them completes (asFail, mostly — Blitz lacks animation support).Reproduced locally: with 8 busy-loop processes saturating the cores, the same test flips
FAILED/TIMED OUTacross runs at multiplier 0.1, and is deterministicallyFAILED(3/3 runs × 5 tests) with this change.Change:
timeout_multiplier: 0.1→0.5(internal timeout 1s → 5s)HARNESS_TIMEOUTbackstop 5s → 10s (so the scaled internal timeout still fires first and hangs get a proper harness TIMEOUT status)Cost is negligible: genuine hangers are already covered by the 259-entry timeout quarantine; the latest full CI run had only 17 TIMEOUT results, nearly all of which are these borderline tests that will now complete instead of waiting out the timeout.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/dbb484350ccd420bb69efaf2f0f462ce
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/dbb484350ccd420bb69efaf2f0f462ce?variant=devin-insiders
Requested by: @nicoburns
WPT results
4 newly passing, 0 newly failing (net +4), 50 other status changes.
Full diff (54 changed tests)
Generated by the WPT workflow.